Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e23db65f authored by Arun Ramamurthy's avatar Arun Ramamurthy Committed by Thierry Reding
Browse files

pwm: bcm-kona: Don't set polarity in probe 



Omit setting the polarity to normal during probe and instead use the new
pwmchip_add_with_polarity() function to register a PWM chip with inverse
polarity by default for all channels to reflect the hardware default.

Signed-off-by: default avatarArun Ramamurthy <arunrama@broadcom.com>
Reviewed-by: default avatarRay Jui <rjui@broadcom.com>
Signed-off-by: default avatarScott Branden <sbranden@broadcom.com>
Signed-off-by: default avatarTim Kryger <tim.kryger@gmail.com>
Signed-off-by: default avatarJonathan Richardson <jonathar@broadcom.com>
[thierry.reding@gmail.com: use pwmchip_add_with_polarity()]
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent b6a00fae

drivers/pwm/pwm-bcm-kona.c

+3 −6
Original line number Diff line number Diff line
@@ -266,18 +266,15 @@ static int kona_pwmc_probe(struct platform_device *pdev) 
		return ret;

	}



	/* Set smooth mode, push/pull, and normal polarity for all channels */

	for (chan = 0; chan < kp->chip.npwm; chan++) {

		value |= (1 << PWM_CONTROL_SMOOTH_SHIFT(chan));

	/* Set push/pull for all channels */

	for (chan = 0; chan < kp->chip.npwm; chan++)

		value |= (1 << PWM_CONTROL_TYPE_SHIFT(chan));

		value |= (1 << PWM_CONTROL_POLARITY_SHIFT(chan));

	}



	writel(value, kp->base + PWM_CONTROL_OFFSET);



	clk_disable_unprepare(kp->clk);



	ret = pwmchip_add(&kp->chip);

	ret = pwmchip_add_with_polarity(&kp->chip, PWM_POLARITY_INVERSED);

	if (ret < 0)

		dev_err(&pdev->dev, "failed to add PWM chip: %d\n", ret);