Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e1990222 authored by Hari Prasath's avatar Hari Prasath Committed by Mauro Carvalho Chehab
Browse files

media: staging: atomisp: use kstrdup to replace kmalloc and memcpy 



kstrdup kernel primitive can be used to replace kmalloc followed by
string copy. This was reported by coccinelle tool.

Signed-off-by: default avatarHari Prasath <gehariprasath@gmail.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent e9e8c1cd

drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c

+2 −6
Original line number Diff line number Diff line
@@ -131,14 +131,10 @@ sh_css_load_blob_info(const char *fw, const struct ia_css_fw_info *bi, struct ia 


	if (bi->type == ia_css_isp_firmware || bi->type == ia_css_sp_firmware) {

		char *namebuffer;

		int namelength = (int)strlen(name);



		namebuffer = (char *) kmalloc(namelength + 1, GFP_KERNEL);

		if (namebuffer == NULL)

		namebuffer = kstrdup(name, GFP_KERNEL);

		if (!namebuffer)

			return IA_CSS_ERR_CANNOT_ALLOCATE_MEMORY;



		memcpy(namebuffer, name, namelength + 1);



		bd->name = fw_minibuffer[index].name = namebuffer;

	} else {

		bd->name = name;