Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e15bea0f authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: gadget: udc: s3c2410_udc: no need to check return value of debugfs_create functions 



When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Felipe Balbi <balbi@kernel.org>
Cc: Li Yang <leoyang.li@nxp.com>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 743d1eff

drivers/usb/gadget/udc/s3c2410_udc.c

+4 −13
Original line number Diff line number Diff line
@@ -1871,13 +1871,9 @@ static int s3c2410_udc_probe(struct platform_device *pdev) 
	if (retval)

		goto err_add_udc;



	if (s3c2410_udc_debugfs_root) {

	udc->regs_info = debugfs_create_file("registers", S_IRUGO,

				s3c2410_udc_debugfs_root,

				udc, &s3c2410_udc_debugfs_fops);

		if (!udc->regs_info)

			dev_warn(dev, "debugfs file creation failed\n");

	}

					     s3c2410_udc_debugfs_root, udc,

					     &s3c2410_udc_debugfs_fops);



	dev_dbg(dev, "probe ok\n");
@@ -1994,11 +1990,6 @@ static int __init udc_init(void) 
	dprintk(DEBUG_NORMAL, "%s\n", gadget_name);



	s3c2410_udc_debugfs_root = debugfs_create_dir(gadget_name, NULL);

	if (IS_ERR(s3c2410_udc_debugfs_root)) {

		pr_err("%s: debugfs dir creation failed %ld\n",

			gadget_name, PTR_ERR(s3c2410_udc_debugfs_root));

		s3c2410_udc_debugfs_root = NULL;

	}



	retval = platform_driver_register(&udc_driver_24x0);

	if (retval)
@@ -2014,7 +2005,7 @@ static int __init udc_init(void) 
static void __exit udc_exit(void)

{

	platform_driver_unregister(&udc_driver_24x0);

	debugfs_remove(s3c2410_udc_debugfs_root);

	debugfs_remove_recursive(s3c2410_udc_debugfs_root);

}



module_init(udc_init);