Commit e0d42298 authored Dec 04, 2017 by Arnd Bergmann Committed by Jacek Anaszewski Jan 08, 2018

leds: blinkm: avoid uninitialized data use



gcc-8 reports missing error handling in blinkm_detect, when blinkm()
fails, tmpargs[] is uninitialized:

drivers/leds/leds-blinkm.c: In function 'blinkm_detect':
drivers/leds/leds-blinkm.c:555:6: error: 'tmpargs' may be used uninitialized in this function [-Werror=maybe-uninitialized]

This adds a missing error checks.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>

parent a72d3b5d

drivers/leds/leds-blinkm.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -549,8 +549,12 @@ static int blinkm_detect(struct i2c_client client, struct i2c_board_info info)
		/* make sure the blinkM is balanced (read/writes) */
		while (count > 0) {
		ret = blinkm_write(client, BLM_GET_ADDR, NULL);
		if (ret)
		return ret;
		usleep_range(5000, 10000);
		ret = blinkm_read(client, BLM_GET_ADDR, tmpargs);
		if (ret)
		return ret;
		usleep_range(5000, 10000);
		if (tmpargs[0] == 0x09)
		count = 0;