Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dffd06a7 authored by Paul E. McKenney's avatar Paul E. McKenney
Browse files

rcu: Semicolon inside RCU_TRACE() for rcu.h 



The current use of "RCU_TRACE(statement);" can cause odd bugs, especially
where "statement" is a local-variable declaration, as it can leave a
misplaced ";" in the source code.  This commit therefore converts these
to "RCU_TRACE(statement;)", which avoids the misplaced ";".

Reported-by: default avatarJosh Triplett <josh@joshtriplett.org>
Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
parent 15c68f7f

kernel/rcu/rcu.h

+2 −2
Original line number Diff line number Diff line
@@ -109,12 +109,12 @@ static inline bool __rcu_reclaim(const char *rn, struct rcu_head *head) 


	rcu_lock_acquire(&rcu_callback_map);

	if (__is_kfree_rcu_offset(offset)) {

		RCU_TRACE(trace_rcu_invoke_kfree_callback(rn, head, offset));

		RCU_TRACE(trace_rcu_invoke_kfree_callback(rn, head, offset);)

		kfree((void *)head - offset);

		rcu_lock_release(&rcu_callback_map);

		return true;

	} else {

		RCU_TRACE(trace_rcu_invoke_callback(rn, head));

		RCU_TRACE(trace_rcu_invoke_callback(rn, head);)

		head->func(head);

		rcu_lock_release(&rcu_callback_map);

		return false;