Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dff51cd1 authored by David Sterba's avatar David Sterba
Browse files

btrfs: ratelimit WARN_ON in use_block_rsv 



The WARN_ON under some circumstances heavily polute log and slow down
the machine. This is just a safety, as the warning should be fixed by
another patch, nevertheless, it still pops up during testing.

Signed-off-by: default avatarDavid Sterba <dsterba@suse.cz>
parent a81d3b1b

fs/btrfs/extent-tree.c

+8 −1
Original line number Diff line number Diff line
@@ -23,6 +23,7 @@ 
#include <linux/rcupdate.h>

#include <linux/kthread.h>

#include <linux/slab.h>

#include <linux/ratelimit.h>

#include "compat.h"

#include "hash.h"

#include "ctree.h"
@@ -5783,7 +5784,13 @@ use_block_rsv(struct btrfs_trans_handle *trans, 
	if (!ret)

		return block_rsv;

	if (ret) {

		static DEFINE_RATELIMIT_STATE(_rs,

				DEFAULT_RATELIMIT_INTERVAL,

				/*DEFAULT_RATELIMIT_BURST*/ 2);

		if (__ratelimit(&_rs)) {

			printk(KERN_DEBUG "btrfs: block rsv returned %d\n", ret);

			WARN_ON(1);

		}

		ret = reserve_metadata_bytes(root, block_rsv, blocksize, 0);

		if (!ret) {

			return block_rsv;