Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dfc0e555 authored by Zhu Yanjun's avatar Zhu Yanjun Committed by Doug Ledford
Browse files

IB/ipoib: function interface change 



The ipoib_ib_dev_down/ipoib_ib_dev_stop return zero unconditionally
and the callers never check the returned values,
change the return type to void and remove the redundant return values.

Reviewed-by: default avatarShan Hai <shan.hai@oracle.com>
Signed-off-by: default avatarZhu Yanjun <yanjun.zhu@oracle.com>
Reviewed-by: default avatarYuval Shaia <yuval.shaia@oracle.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 820cd30a

drivers/infiniband/ulp/ipoib/ipoib.h

+2 −2
Original line number Diff line number Diff line
@@ -501,8 +501,8 @@ void ipoib_ib_dev_cleanup(struct net_device *dev); 


int ipoib_ib_dev_open(struct net_device *dev);

int ipoib_ib_dev_up(struct net_device *dev);

int ipoib_ib_dev_down(struct net_device *dev);

int ipoib_ib_dev_stop(struct net_device *dev);

void ipoib_ib_dev_down(struct net_device *dev);

void ipoib_ib_dev_stop(struct net_device *dev);

void ipoib_pkey_dev_check_presence(struct net_device *dev);



int ipoib_dev_init(struct net_device *dev, struct ib_device *ca, int port);

drivers/infiniband/ulp/ipoib/ipoib_ib.c

+2 −6
Original line number Diff line number Diff line
@@ -771,7 +771,7 @@ int ipoib_ib_dev_up(struct net_device *dev) 
	return ipoib_mcast_start_thread(dev);

}



int ipoib_ib_dev_down(struct net_device *dev)

void ipoib_ib_dev_down(struct net_device *dev)

{

	struct ipoib_dev_priv *priv = netdev_priv(dev);
@@ -784,8 +784,6 @@ int ipoib_ib_dev_down(struct net_device *dev) 
	ipoib_mcast_dev_flush(dev);



	ipoib_flush_paths(dev);



	return 0;

}



static int recvs_pending(struct net_device *dev)
@@ -840,7 +838,7 @@ void ipoib_drain_cq(struct net_device *dev) 
	local_bh_enable();

}



int ipoib_ib_dev_stop(struct net_device *dev)

void ipoib_ib_dev_stop(struct net_device *dev)

{

	struct ipoib_dev_priv *priv = netdev_priv(dev);

	struct ib_qp_attr qp_attr;
@@ -913,8 +911,6 @@ int ipoib_ib_dev_stop(struct net_device *dev) 
	ipoib_flush_ah(dev);



	ib_req_notify_cq(priv->recv_cq, IB_CQ_NEXT_COMP);



	return 0;

}



int ipoib_ib_dev_init(struct net_device *dev, struct ib_device *ca, int port)