Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit df4198b1 authored by Jason Wang's avatar Jason Wang Committed by Michael S. Tsirkin
Browse files

virtio-input: reset device and detach unused during remove 



Spec requires a device reset during cleanup, so do it and avoid warn
in virtio core. And detach unused buffers to avoid memory leak.

Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 74d33293

drivers/virtio/virtio_input.c

+4 −0
Original line number Diff line number Diff line
@@ -313,6 +313,7 @@ static int virtinput_probe(struct virtio_device *vdev) 
static void virtinput_remove(struct virtio_device *vdev)

{

	struct virtio_input *vi = vdev->priv;

	void *buf;

	unsigned long flags;



	spin_lock_irqsave(&vi->lock, flags);
@@ -320,6 +321,9 @@ static void virtinput_remove(struct virtio_device *vdev) 
	spin_unlock_irqrestore(&vi->lock, flags);



	input_unregister_device(vi->idev);

	vdev->config->reset(vdev);

	while ((buf = virtqueue_detach_unused_buf(vi->sts)) != NULL)

		kfree(buf);

	vdev->config->del_vqs(vdev);

	kfree(vi);

}