Commit deaf7e1c authored Feb 06, 2016 by Oleg Drokin Committed by Greg Kroah-Hartman Feb 07, 2016

staging/lustre/lnet: Don't call roundup_pow_of_two on zero in LNetEQAlloc



roundup_pow_of_two return when called on a zero argument is
undefined, so don't call it like that.

This fixes a problem introduced by commit 322489d9
("staging/lustre: Use roundup_pow_of_two() in LNetEQAlloc()")
since 0 is a valid count parameter for LNetEQAlloc. Also manifesting
itself as an annoying kernel warning:
LNet: 3486:0:(lib-eq.c:85:LNetEQAlloc()) EQ callback is guaranteed to get every event, do you still want to set eqcount 1 for polling event which will have locking overhead? Please contact with developer to confirm

Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
CC: Pekka Enberg <penberg@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent da33f1dd

drivers/staging/lustre/lnet/lnet/lib-eq.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -79,6 +79,7 @@ LNetEQAlloc(unsigned int count, lnet_eq_handler_t callback,
		* overflow, they don't skip entries, so the queue has the same
		* apparent capacity at all times */

		if (count)
		count = roundup_pow_of_two(count);

		if (callback != LNET_EQ_HANDLER_NONE && count != 0)