Commit de4d768a authored Mar 13, 2011 by Michael S. Tsirkin

vhost-net: remove unlocked use of receive_queue



Use of skb_queue_empty(&sock->sk->sk_receive_queue)
without taking the sk_receive_queue.lock is unsafe
or useless. Take it out.

Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

parent 783e3988

drivers/vhost/net.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -311,7 +311,7 @@ static void handle_rx(struct vhost_net *net)
		/* TODO: check that we are running from vhost_worker? */
		struct socket *sock = rcu_dereference_check(vq->private_data, 1);

		if (!sock \|\| skb_queue_empty(&sock->sk->sk_receive_queue))
		if (!sock)
		return;

		mutex_lock(&vq->mutex);