Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dded0692 authored by Sven Eckelmann's avatar Sven Eckelmann Committed by Antonio Quartulli
Browse files

batman-adv: Add lockdep assert for container_list_lock 



The batadv_tvlv_container* functions state in their kernel-doc that they
require tvlv.container_list_lock. Add an assert to automatically detect
when this might have been ignored by the caller.

Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
Signed-off-by: default avatarMarek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: default avatarAntonio Quartulli <a@unstable.cc>
parent 81f02683

net/batman-adv/main.c

+4 −0
Original line number Diff line number Diff line
@@ -697,6 +697,8 @@ static struct batadv_tvlv_container 
{

	struct batadv_tvlv_container *tvlv_tmp, *tvlv = NULL;



	lockdep_assert_held(&bat_priv->tvlv.container_list_lock);



	hlist_for_each_entry(tvlv_tmp, &bat_priv->tvlv.container_list, list) {

		if (tvlv_tmp->tvlv_hdr.type != type)

			continue;
@@ -729,6 +731,8 @@ static u16 batadv_tvlv_container_list_size(struct batadv_priv *bat_priv) 
	struct batadv_tvlv_container *tvlv;

	u16 tvlv_len = 0;



	lockdep_assert_held(&bat_priv->tvlv.container_list_lock);



	hlist_for_each_entry(tvlv, &bat_priv->tvlv.container_list, list) {

		tvlv_len += sizeof(struct batadv_tvlv_hdr);

		tvlv_len += ntohs(tvlv->tvlv_hdr.len);