Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ddd5115f authored by Namhyung Kim's avatar Namhyung Kim Committed by NeilBrown
Browse files

md/raid5: move rdev->corrected_errors counting 



Read errors are considered to corrected if write-back and re-read
cycle is finished without further problems. Thus moving the rdev->
corrected_errors counting after the re-reading looks more reasonable
IMHO.

Signed-off-by: default avatarNamhyung Kim <namhyung@gmail.com>
Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent 9d3d8011

drivers/md/raid5.c

+1 −4
Original line number Diff line number Diff line
@@ -547,10 +547,6 @@ static void ops_run_io(struct stripe_head *sh, struct stripe_head_state *s) 
			bi->bi_io_vec[0].bv_offset = 0;

			bi->bi_size = STRIPE_SIZE;

			bi->bi_next = NULL;

			if ((rw & WRITE) &&

			    test_bit(R5_ReWrite, &sh->dev[i].flags))

				atomic_add(STRIPE_SECTORS,

					&rdev->corrected_errors);

			generic_make_request(bi);

		} else {

			if (rw & WRITE)
@@ -1590,6 +1586,7 @@ static void raid5_end_read_request(struct bio * bi, int error) 
				(unsigned long long)(sh->sector

						     + rdev->data_offset),

				bdevname(rdev->bdev, b));

			atomic_add(STRIPE_SECTORS, &rdev->corrected_errors);

			clear_bit(R5_ReadError, &sh->dev[i].flags);

			clear_bit(R5_ReWrite, &sh->dev[i].flags);

		}