Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ddc5c1f7 authored by Ezequiel Garcia's avatar Ezequiel Garcia Committed by Mauro Carvalho Chehab
Browse files

media: rockchip/rga: Fix bad dma_free_attrs() parameter 



In rga_remove(), dma_free_attrs is being passed the wrong
cpu address, which triggers an exception if the driver is
removed. Fix it.

Tested on a RK3399 platform, with a bind/unbind cycle.

Signed-off-by: default avatarEzequiel Garcia <ezequiel@collabora.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 87e1a881

drivers/media/platform/rockchip/rga/rga.c

+1 −1
Original line number Diff line number Diff line
@@ -925,7 +925,7 @@ static int rga_remove(struct platform_device *pdev) 
{

	struct rockchip_rga *rga = platform_get_drvdata(pdev);



	dma_free_attrs(rga->dev, RGA_CMDBUF_SIZE, &rga->cmdbuf_virt,

	dma_free_attrs(rga->dev, RGA_CMDBUF_SIZE, rga->cmdbuf_virt,

		       rga->cmdbuf_phy, DMA_ATTR_WRITE_COMBINE);



	free_pages((unsigned long)rga->src_mmu_pages, 3);