Commit dd6bc6ac authored Aug 28, 2019 by Chao Yu Committed by Jaegeuk Kim Sep 23, 2019

f2fs: fix to fallback to buffered IO in IO aligned mode



In LFS mode, we allow OPU for direct IO, however, we didn't consider
IO alignment feature, so direct IO can trigger unaligned IO, let's
just fallback to buffered IO to keep correct IO alignment semantics
in all places.

Fixes: f847c699cff3 ("f2fs: allow out-place-update for direct IO in LFS mode")
Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

parent 1fd4f349

fs/f2fs/f2fs.h

+6 −3

Original line number	Diff line number	Diff line
		@@ -3719,9 +3719,12 @@ static inline bool f2fs_force_buffered_io(struct inode *inode,
		*/
		if (f2fs_sb_has_blkzoned(sbi))
		return true;
		if (test_opt(sbi, LFS) && (rw == WRITE) &&
		block_unaligned_IO(inode, iocb, iter))
		if (test_opt(sbi, LFS) && (rw == WRITE)) {
		if (block_unaligned_IO(inode, iocb, iter))
		return true;
		if (F2FS_IO_ALIGNED(sbi))
		return true;
		}
		if (is_sbi_flag_set(F2FS_I_SB(inode), SBI_CP_DISABLED) &&
		!IS_SWAPFILE(inode))
		return true;