Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dcdaa2f9 authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge branch 'stable-4.10' of git://git.infradead.org/users/pcmoore/audit 

Pull audit updates from Paul Moore:
 "After the small number of patches for v4.9, we've got a much bigger
  pile for v4.10.

  The bulk of these patches involve a rework of the audit backlog queue
  to enable us to move the netlink multicasting out of the task/thread
  that generates the audit record and into the kernel thread that emits
  the record (just like we do for the audit unicast to auditd).

  While we were playing with the backlog queue(s) we fixed a number of
  other little problems with the code, and from all the testing so far
  things look to be in much better shape now. Doing this also allowed us
  to re-enable disabling IRQs for some netns operations ("netns: avoid
  disabling irq for netns id").

  The remaining patches fix some small problems that are well documented
  in the commit descriptions, as well as adding session ID filtering
  support"

* 'stable-4.10' of git://git.infradead.org/users/pcmoore/audit:
  audit: use proper refcount locking on audit_sock
  netns: avoid disabling irq for netns id
  audit: don't ever sleep on a command record/message
  audit: handle a clean auditd shutdown with grace
  audit: wake up kauditd_thread after auditd registers
  audit: rework audit_log_start()
  audit: rework the audit queue handling
  audit: rename the queues and kauditd related functions
  audit: queue netlink multicast sends just like we do for unicast sends
  audit: fixup audit_init()
  audit: move kaudit thread start from auditd registration to kaudit init (#2)
  audit: add support for session ID user filter
  audit: fix formatting of AUDIT_CONFIG_CHANGE events
  audit: skip sessionid sentinel value when auto-incrementing
  audit: tame initialization warning len_abuf in audit_log_execve_info
  audit: less stack usage for /proc/*/loginuid
parents 683b96f4 533c7b69

fs/proc/base.c

+1 −1
Original line number Diff line number Diff line
@@ -1246,7 +1246,7 @@ static const struct file_operations proc_oom_score_adj_operations = { 
};



#ifdef CONFIG_AUDITSYSCALL

#define TMPBUFLEN 21

#define TMPBUFLEN 11

static ssize_t proc_loginuid_read(struct file * file, char __user * buf,

				  size_t count, loff_t *ppos)

{

include/uapi/linux/audit.h

+4 −1
Original line number Diff line number Diff line
@@ -254,6 +254,7 @@ 
#define AUDIT_OBJ_LEV_LOW	22

#define AUDIT_OBJ_LEV_HIGH	23

#define AUDIT_LOGINUID_SET	24

#define AUDIT_SESSIONID	25	/* Session ID */



				/* These are ONLY useful when checking

				 * at syscall exit time (AUDIT_AT_EXIT). */
@@ -330,10 +331,12 @@ enum { 
#define AUDIT_FEATURE_BITMAP_BACKLOG_WAIT_TIME	0x00000002

#define AUDIT_FEATURE_BITMAP_EXECUTABLE_PATH	0x00000004

#define AUDIT_FEATURE_BITMAP_EXCLUDE_EXTEND	0x00000008

#define AUDIT_FEATURE_BITMAP_SESSIONID_FILTER	0x00000010

#define AUDIT_FEATURE_BITMAP_ALL (AUDIT_FEATURE_BITMAP_BACKLOG_LIMIT | \

				  AUDIT_FEATURE_BITMAP_BACKLOG_WAIT_TIME | \

				  AUDIT_FEATURE_BITMAP_EXECUTABLE_PATH | \

				  AUDIT_FEATURE_BITMAP_EXCLUDE_EXTEND)

				  AUDIT_FEATURE_BITMAP_EXCLUDE_EXTEND | \

				  AUDIT_FEATURE_BITMAP_SESSIONID_FILTER)



/* deprecated: AUDIT_VERSION_* */

#define AUDIT_VERSION_LATEST 		AUDIT_FEATURE_BITMAP_ALL

kernel/audit.c

+323 −209

File changed.

Preview size limit exceeded, changes collapsed.

kernel/audit_fsnotify.c

+2 −3
Original line number Diff line number Diff line
@@ -130,10 +130,9 @@ static void audit_mark_log_rule_change(struct audit_fsnotify_mark *audit_mark, c 
	ab = audit_log_start(NULL, GFP_NOFS, AUDIT_CONFIG_CHANGE);

	if (unlikely(!ab))

		return;

	audit_log_format(ab, "auid=%u ses=%u op=",

	audit_log_format(ab, "auid=%u ses=%u op=%s",

			 from_kuid(&init_user_ns, audit_get_loginuid(current)),

			 audit_get_sessionid(current));

	audit_log_string(ab, op);

			 audit_get_sessionid(current), op);

	audit_log_format(ab, " path=");

	audit_log_untrustedstring(ab, audit_mark->path);

	audit_log_key(ab, rule->filterkey);

kernel/audit_tree.c

+1 −2
Original line number Diff line number Diff line
@@ -458,8 +458,7 @@ static void audit_tree_log_remove_rule(struct audit_krule *rule) 
	ab = audit_log_start(NULL, GFP_KERNEL, AUDIT_CONFIG_CHANGE);

	if (unlikely(!ab))

		return;

	audit_log_format(ab, "op=");

	audit_log_string(ab, "remove_rule");

	audit_log_format(ab, "op=remove_rule");

	audit_log_format(ab, " dir=");

	audit_log_untrustedstring(ab, rule->tree->pathname);

	audit_log_key(ab, rule->filterkey);