Commit dcb73eed authored Oct 13, 2009 by Rakib Mullick Committed by Len Brown Oct 13, 2009

eeepc-laptop: Properly annote eeepc_enable_camera().



Currently the annotation for function eeepc_enable_camera() is
__init, and refers to a
function eeepc_hotk_add() which is non-init. Use __devinit for both
functions which is
more appropriate and fixes a section mismatch warning.

 We were warned by the following warning:

  LD      drivers/platform/x86/built-in.o
WARNING: drivers/platform/x86/built-in.o(.text+0x12e1): Section
mismatch in reference from the function eeepc_hotk_add() to the
function .init.text:eeepc_enable_camera()
The function eeepc_hotk_add() references
the function __init eeepc_enable_camera().
This is often because eeepc_hotk_add lacks a __init
annotation or the annotation of eeepc_enable_camera is wrong.

Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
Signed-off-by: Corentin Chary <corentincj@iksaif.net>
Signed-off-by: Len Brown <len.brown@intel.com>

parent 16129139

drivers/platform/x86/eeepc-laptop.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -350,7 +350,7 @@ static const struct rfkill_ops eeepc_rfkill_ops = {
		.set_block = eeepc_rfkill_set,
		};

		static void __init eeepc_enable_camera(void)
		static void __devinit eeepc_enable_camera(void)
		{
		/*
		* If the following call to set_acpi() fails, it's because there's no
		@@ -1189,7 +1189,7 @@ static int eeepc_input_init(struct device *dev)
		return 0;
		}

		static int eeepc_hotk_add(struct acpi_device *device)
		static int __devinit eeepc_hotk_add(struct acpi_device *device)
		{
		struct device *dev;
		int result;