Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db82476f authored by Håkon Bugge's avatar Håkon Bugge Committed by Doug Ledford
Browse files

IB/core: Make ib_mad_client_id atomic 



Currently, the kernel protects access to the agent ID allocator on a per
port basis using a spinlock, so it is impossible for two apps/threads on
the same port to get the same TID, but it is entirely possible for two
threads on different ports to end up with the same TID.

As this can be confusing (regardless of it being legal according to the
IB Spec 1.3, C13-18.1.1, in section 13.4.6.4 - TransactionID usage),
and as the rdma-core user space API for /dev/umad devices implies unique
TIDs even across ports, make the TID an atomic type so that no two
allocations, regardless of port number, will be the same.

Signed-off-by: default avatarHåkon Bugge <haakon.bugge@oracle.com>
Reviewed-by: default avatarJack Morgenstein <jackm@dev.mellanox.co.il>
Reviewed-by: default avatarIra Weiny <ira.weiny@intel.com>
Reviewed-by: default avatarZhu Yanjun <yanjun.zhu@oracle.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 2df19e19

drivers/infiniband/core/mad.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -59,7 +59,7 @@ module_param_named(recv_queue_size, mad_recvq_size, int, 0444); 
MODULE_PARM_DESC(recv_queue_size, "Size of receive queue in number of work requests");

MODULE_PARM_DESC(recv_queue_size, "Size of receive queue in number of work requests");





static struct list_head ib_mad_port_list;

static struct list_head ib_mad_port_list;

static u32 ib_mad_client_id = 0;

static atomic_t ib_mad_client_id = ATOMIC_INIT(0);





/* Port list lock */

/* Port list lock */

static DEFINE_SPINLOCK(ib_mad_port_list_lock);

static DEFINE_SPINLOCK(ib_mad_port_list_lock);
@@ -377,7 +377,7 @@ struct ib_mad_agent *ib_register_mad_agent(struct ib_device *device, 
	}

	}





	spin_lock_irqsave(&port_priv->reg_lock, flags);

	spin_lock_irqsave(&port_priv->reg_lock, flags);

	mad_agent_priv->agent.hi_tid = ++ib_mad_client_id;

	mad_agent_priv->agent.hi_tid = atomic_inc_return(&ib_mad_client_id);





	/*

	/*

	 * Make sure MAD registration (if supplied)

	 * Make sure MAD registration (if supplied)