Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dad5980e authored by Tobin C. Harding's avatar Tobin C. Harding Committed by Greg Kroah-Hartman
Browse files

staging: ks7010: refactor function call parameters 



Function call parameters are split over more lines than
necessary. Also assignment statements are split after the '=' sign.
This adds extra lines to the function and may also reduces
readability.

Refactor function call parameters and reduce the number of lines
used. Put assignment statements onto single line.

Signed-off-by: default avatarTobin C. Harding <me@tobin.cc>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3188bc09

drivers/staging/ks7010/ks7010_sdio.c

+13 −27
Original line number Diff line number Diff line
@@ -195,48 +195,34 @@ static int _ks_wlan_hw_power_save(struct ks_wlan_private *priv) 
	if (!atomic_read(&priv->psstatus.confirm_wait) &&

		!atomic_read(&priv->psstatus.snooze_guard) &&

		!cnt_txqbody(priv)) {

		retval =

			ks7010_sdio_read(priv, INT_PENDING,

					&rw_data,

		retval = ks7010_sdio_read(priv, INT_PENDING, &rw_data,

					  sizeof(rw_data));

		if (retval) {

			DPRINTK(1,

				" error : INT_PENDING=%02X\n",

				rw_data);

			DPRINTK(1, " error : INT_PENDING=%02X\n", rw_data);

			queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,

					   &priv->ks_wlan_hw.rw_wq, 1);

			return 0;

		}

		if (!rw_data) {

			rw_data = GCR_B_DOZE;

			retval =

				ks7010_sdio_write(priv,

						GCR_B,

						&rw_data,

			retval = ks7010_sdio_write(priv, GCR_B, &rw_data,

						   sizeof(rw_data));

			if (retval) {

				DPRINTK(1,

					" error : GCR_B=%02X\n",

					rw_data);

				queue_delayed_work

					(priv->ks_wlan_hw.ks7010sdio_wq,

				DPRINTK(1, " error : GCR_B=%02X\n", rw_data);

				queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,

						   &priv->ks_wlan_hw.rw_wq, 1);

				return 0;

			}

			DPRINTK(4,

				"PMG SET!! : GCR_B=%02X\n",

				rw_data);

			DPRINTK(4, "PMG SET!! : GCR_B=%02X\n", rw_data);

			atomic_set(&priv->psstatus.status, PS_SNOOZE);

			DPRINTK(3,

				"psstatus.status=PS_SNOOZE\n");

			DPRINTK(3, "psstatus.status=PS_SNOOZE\n");

		} else {

			queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,

					   &priv->ks_wlan_hw.rw_wq, 1);

		}

	} else {

		queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,

				&priv->ks_wlan_hw.rw_wq,

				0);

				   &priv->ks_wlan_hw.rw_wq, 0);

	}



	return 0;