Commit dacb5822 authored Jan 20, 2016 by Himanshu Madhani Committed by Nicholas Bellinger Jan 29, 2016

qla2xxx: Fix warning reported by static checker



This patch fixes following warning

drivers/scsi/qla2xxx/qla_target.c:3587 qlt_do_ctio_completion()
warn: impossible condition '(logged_out == 41) => (0-1 == 41)'

drivers/scsi/qla2xxx/qla_target.c
 3580                  case CTIO_PORT_LOGGED_OUT:
 3581                  case CTIO_PORT_UNAVAILABLE:
 3582                  {
 3583                          bool logged_out = (status & 0xFFFF);
 3584                          ql_dbg(ql_dbg_tgt_mgt, vha, 0xf059,
 3585                              "qla_target(%d): CTIO with %s status %x "
 3586                              "received (state %x, se_cmd %p)\n", vha->vp_idx,
 3587                              (logged_out == CTIO_PORT_LOGGED_OUT) ?
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                    Bool cannot equal 0x26.
 3588                              "PORT LOGGED OUT" : "PORT UNAVAILABLE",

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent 8a9ebe71

drivers/scsi/qla2xxx/qla_target.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -3580,12 +3580,13 @@ static void qlt_do_ctio_completion(struct scsi_qla_host *vha, uint32_t handle,
		case CTIO_PORT_LOGGED_OUT:
		case CTIO_PORT_UNAVAILABLE:
		{
		int logged_out = (status & 0xFFFF);
		int logged_out =
		(status & 0xFFFF) == CTIO_PORT_LOGGED_OUT;

		ql_dbg(ql_dbg_tgt_mgt, vha, 0xf059,
		"qla_target(%d): CTIO with %s status %x "
		"received (state %x, se_cmd %p)\n", vha->vp_idx,
		(logged_out == CTIO_PORT_LOGGED_OUT) ?
		"PORT LOGGED OUT" : "PORT UNAVAILABLE",
		logged_out ? "PORT LOGGED OUT" : "PORT UNAVAILABLE",
		status, cmd->state, se_cmd);

		if (logged_out && cmd->sess) {