Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dab734ec authored by Antti Palosaari's avatar Antti Palosaari Committed by Mauro Carvalho Chehab
Browse files

[media] hd29l2: fix review findings 



Fix some issues pointed out by Mauro.
Mauro Carvalho Chehab <mchehab@redhat.com>

Signed-off-by: default avatarAntti Palosaari <crope@iki.fi>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent b748e6a9

drivers/media/dvb/frontends/hd29l2.c

+3 −3
Original line number Diff line number Diff line
@@ -476,7 +476,7 @@ static enum dvbfe_search hd29l2_search(struct dvb_frontend *fe) 


	/* ensure modulation validy */

	/* 0=QAM4_NR, 1=QAM4, 2=QAM16, 3=QAM32, 4=QAM64 */

	if (modulation > 4) {

	if (modulation > (ARRAY_SIZE(reg_mod_vals_tab[0].val) - 1)) {

		dbg("%s: modulation=%d not valid", __func__, modulation);

		goto err;

	}
@@ -735,7 +735,7 @@ static int hd29l2_init(struct dvb_frontend *fe) 
	/* reset demod */

	/* it is recommended to HW reset chip using RST_N pin */

	if (fe->callback) {

		ret = fe->callback(fe, 0, 0, 0);

		ret = fe->callback(fe, DVB_FRONTEND_COMPONENT_DEMOD, 0, 0);

		if (ret)

			goto err;