Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit da39822c authored by Sage Weil's avatar Sage Weil
Browse files

ceph: fix broken comparison in readdir loop 



Both off and fi->offset are unsigned, so the difference is always >= 0.
Compare them directly instead of the sign of the difference.

Signed-off-by: default avatarSage Weil <sage@newdream.net>
parent 31456665

fs/ceph/dir.c

+1 −1
Original line number Diff line number Diff line
@@ -360,7 +360,7 @@ static int ceph_readdir(struct file *filp, void *dirent, filldir_t filldir) 
	rinfo = &fi->last_readdir->r_reply_info;

	dout("readdir frag %x num %d off %d chunkoff %d\n", frag,

	     rinfo->dir_nr, off, fi->offset);

	while (off - fi->offset >= 0 && off - fi->offset < rinfo->dir_nr) {

	while (off >= fi->offset && off - fi->offset < rinfo->dir_nr) {

		u64 pos = ceph_make_fpos(frag, off);

		struct ceph_mds_reply_inode *in =

			rinfo->dir_in[off - fi->offset].in;