Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d9fa482e authored by Corentin LABBE's avatar Corentin LABBE Committed by Herbert Xu
Browse files

crypto: bcm - use of_device_get_match_data 



The usage of of_device_get_match_data reduce the code size a bit.
Furthermore, it prevents an improbable dereference when
of_match_device() return NULL.

Signed-off-by: default avatarCorentin Labbe <clabbe.montjoie@gmail.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 7d556931

drivers/crypto/bcm/cipher.c

+2 −5
Original line number Diff line number Diff line
@@ -4809,7 +4809,6 @@ static int spu_dt_read(struct platform_device *pdev) 
	struct device *dev = &pdev->dev;

	struct spu_hw *spu = &iproc_priv.spu;

	struct resource *spu_ctrl_regs;

	const struct of_device_id *match;

	const struct spu_type_subtype *matched_spu_type;

	struct device_node *dn = pdev->dev.of_node;

	int err, i;
@@ -4817,14 +4816,12 @@ static int spu_dt_read(struct platform_device *pdev) 
	/* Count number of mailbox channels */

	spu->num_chan = of_count_phandle_with_args(dn, "mboxes", "#mbox-cells");



	match = of_match_device(of_match_ptr(bcm_spu_dt_ids), dev);

	if (!match) {

	matched_spu_type = of_device_get_match_data(dev);

	if (!matched_spu_type) {

		dev_err(&pdev->dev, "Failed to match device\n");

		return -ENODEV;

	}



	matched_spu_type = match->data;



	spu->spu_type = matched_spu_type->type;

	spu->spu_subtype = matched_spu_type->subtype;