Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d9c9df8c authored by Al Viro's avatar Al Viro Committed by David S. Miller
Browse files

[IPV4]: fib_validate_source() annotations 



annotated arguments and inferred net-endian variables in callers

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a61ced5d

include/net/ip_fib.h

+2 −2
Original line number Diff line number Diff line
@@ -222,8 +222,8 @@ extern int inet_rtm_delroute(struct sk_buff *skb, struct nlmsghdr* nlh, void *ar 
extern int inet_rtm_newroute(struct sk_buff *skb, struct nlmsghdr* nlh, void *arg);

extern int inet_rtm_getroute(struct sk_buff *skb, struct nlmsghdr* nlh, void *arg);

extern int inet_dump_fib(struct sk_buff *skb, struct netlink_callback *cb);

extern int fib_validate_source(u32 src, u32 dst, u8 tos, int oif,

			       struct net_device *dev, u32 *spec_dst, u32 *itag);

extern int fib_validate_source(__be32 src, __be32 dst, u8 tos, int oif,

			       struct net_device *dev, __be32 *spec_dst, u32 *itag);

extern void fib_select_multipath(const struct flowi *flp, struct fib_result *res);



struct rtentry;

net/ipv4/fib_frontend.c

+2 −2
Original line number Diff line number Diff line
@@ -180,8 +180,8 @@ unsigned inet_addr_type(u32 addr) 
   - check, that packet arrived from expected physical interface.

 */



int fib_validate_source(u32 src, u32 dst, u8 tos, int oif,

			struct net_device *dev, u32 *spec_dst, u32 *itag)

int fib_validate_source(__be32 src, __be32 dst, u8 tos, int oif,

			struct net_device *dev, __be32 *spec_dst, u32 *itag)

{

	struct in_device *in_dev;

	struct flowi fl = { .nl_u = { .ip4_u =

net/ipv4/route.c

+2 −1
Original line number Diff line number Diff line
@@ -1722,7 +1722,8 @@ static inline int __mkroute_input(struct sk_buff *skb, 
	int err;

	struct in_device *out_dev;

	unsigned flags = 0;

	u32 spec_dst, itag;

	__be32 spec_dst;

	u32 itag;



	/* get a working reference to the output device */

	out_dev = in_dev_get(FIB_RES_DEV(*res));