Commit d9b86937 authored Dec 06, 2017 by Prashant Bhole Committed by David S. Miller Dec 06, 2017

rds: debug: fix null check on static array



t_name cannot be NULL since it is an array field of a struct.
Replacing null check on static array with string length check using
strnlen()

Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
Acked-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 4bee00eb

net/rds/connection.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -230,8 +230,8 @@ static struct rds_connection __rds_conn_create(struct net net,

		rdsdebug("allocated conn %p for %pI4 -> %pI4 over %s %s\n",
		conn, &laddr, &faddr,
		trans->t_name ? trans->t_name : "[unknown]",
		is_outgoing ? "(outgoing)" : "");
		strnlen(trans->t_name, sizeof(trans->t_name)) ? trans->t_name :
		"[unknown]", is_outgoing ? "(outgoing)" : "");

		/*
		* Since we ran without holding the conn lock, someone could