Commit d91cfeb0 authored Jul 17, 2018 by RAGHU Halharvi Committed by Thomas Gleixner Jul 17, 2018

genirq: Remove redundant NULL pointer check in __free_irq()



The NULL pointer check in __free_irq() triggers a 'dereference before NULL
pointer check' warning in static code analysis. It turns out that the check
is redundant because all callers have a NULL pointer check already.

Remove it.

Signed-off-by: RAGHU Halharvi <raghuhack78@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20180717102009.7708-1-raghuhack78@gmail.com

parent 519cc865

kernel/irq/manage.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -1570,9 +1570,6 @@ static struct irqaction __free_irq(struct irq_desc desc, void *dev_id)

		WARN(in_interrupt(), "Trying to free IRQ %d from IRQ context!\n", irq);

		if (!desc)
		return NULL;

		mutex_lock(&desc->request_mutex);
		chip_bus_lock(desc);
		raw_spin_lock_irqsave(&desc->lock, flags);