Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d89bd919 authored by Bjorn Helgaas's avatar Bjorn Helgaas Committed by Bjorn Helgaas
Browse files

PCI: Report quirk timings with pci_info() instead of pr_debug() 



With "initcall_debug", we report how long every PCI quirk took.  Previously
we used pr_debug(), which means you have to figure out how to enable debug
output.

Log these timings using pci_info() instead so it doesn't depend on DEBUG,
CONFIG_DYNAMIC_DEBUG, etc.

Also, don't log anything at all unless "initcall_debug" is specified.  This
matches what we do in do_one_initcall_debug().

Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent 9df1c6ec

drivers/pci/quirks.c

+2 −5
Original line number Diff line number Diff line
@@ -3106,10 +3106,8 @@ static ktime_t fixup_debug_start(struct pci_dev *dev, 
{

	ktime_t calltime = 0;



	pci_dbg(dev, "calling %pF\n", fn);

	if (initcall_debug) {

		pr_debug("calling  %pF @ %i for %s\n",

			 fn, task_pid_nr(current), dev_name(&dev->dev));

		pci_info(dev, "calling  %pF @ %i\n", fn, task_pid_nr(current));

		calltime = ktime_get();

	}
@@ -3126,8 +3124,7 @@ static void fixup_debug_report(struct pci_dev *dev, ktime_t calltime, 
		rettime = ktime_get();

		delta = ktime_sub(rettime, calltime);

		duration = (unsigned long long) ktime_to_ns(delta) >> 10;

		pr_debug("pci fixup %pF returned after %lld usecs for %s\n",

			 fn, duration, dev_name(&dev->dev));

		pci_info(dev, "%pF took %lld usecs\n", fn, duration);

	}

}