Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d8985fd2 authored by Anton Vorontsov's avatar Anton Vorontsov Committed by Kumar Gala
Browse files

[POWERPC] qe_lib: fix few fluffy negligences 



One is intoduced by me (of_node_put() absence) and another was
present already (not checking for NULL).

Found by Stephen Rothwell.

Signed-off-by: default avatarAnton Vorontsov <avorontsov@ru.mvista.com>
Acked-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: default avatarKumar Gala <galak@kernel.crashing.org>
parent e1664ee9

arch/powerpc/sysdev/qe_lib/qe.c

+5 −5
Original line number Diff line number Diff line
@@ -66,7 +66,7 @@ phys_addr_t get_qe_base(void) 
{

	struct device_node *qe;

	unsigned int size;

	const void *prop;

	const u32 *prop;



	if (qebase != -1)

		return qebase;
@@ -79,6 +79,7 @@ phys_addr_t get_qe_base(void) 
	}



	prop = of_get_property(qe, "reg", &size);

	if (prop && size >= sizeof(*prop))

		qebase = of_translate_address(qe, prop);

	of_node_put(qe);
@@ -172,10 +173,9 @@ unsigned int get_brg_clk(void) 
	}



	prop = of_get_property(qe, "brg-frequency", &size);

	if (!prop || size != sizeof(*prop))

		return brg_clk;



	if (prop && size == sizeof(*prop))

		brg_clk = *prop;



	of_node_put(qe);



	return brg_clk;