Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d7fc6cfd authored by Colin Ian King's avatar Colin Ian King Committed by Herbert Xu
Browse files

crypto: chelsio - remove redundant assignments to reqctx and dst_size 



Pointer reqctx is assigned the same value twice, once on initialization
and again a few statements later, remove the second redundant assignment.
Variable dst_size is assigned but it is never read, so the variable is
redundant and can be removed. Cleans up clang warnings:

drivers/crypto/chelsio/chcr_algo.c:156:29: warning: Value stored to
'reqctx' during its initialization is never read
drivers/crypto/chelsio/chcr_algo.c:2020:2: warning: Value stored to
'dst_size' is never read

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 0c2616a7

drivers/crypto/chelsio/chcr_algo.c

+0 −4
Original line number Diff line number Diff line
@@ -160,7 +160,6 @@ static inline void chcr_handle_ahash_resp(struct ahash_request *req, 


	if (input == NULL)

		goto out;

	reqctx = ahash_request_ctx(req);

	digestsize = crypto_ahash_digestsize(crypto_ahash_reqtfm(req));

	if (reqctx->is_sg_map)

		chcr_hash_dma_unmap(&u_ctx->lldi.pdev->dev, req);
@@ -2014,11 +2013,8 @@ static int chcr_aead_common_init(struct aead_request *req, 
	struct chcr_aead_ctx *aeadctx = AEAD_CTX(a_ctx(tfm));

	struct chcr_aead_reqctx  *reqctx = aead_request_ctx(req);

	int error = -EINVAL;

	unsigned int dst_size;

	unsigned int authsize = crypto_aead_authsize(tfm);



	dst_size = req->assoclen + req->cryptlen + (op_type ?

					-authsize : authsize);

	/* validate key size */

	if (aeadctx->enckey_len == 0)

		goto err;