Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d75f482e authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Herbert Xu
Browse files

crypto: rmd256 - use swap macro in rmd256_transform 



Make use of the swap macro and remove unnecessary variable *tmp*.
This makes the code easier to read and maintain.

This code was detected with the help of Coccinelle.

Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 6b0daa78

crypto/rmd256.c

+5 −5
Original line number Diff line number Diff line
@@ -49,7 +49,7 @@ struct rmd256_ctx { 


static void rmd256_transform(u32 *state, const __le32 *in)

{

	u32 aa, bb, cc, dd, aaa, bbb, ccc, ddd, tmp;

	u32 aa, bb, cc, dd, aaa, bbb, ccc, ddd;



	/* Initialize left lane */

	aa = state[0];
@@ -100,7 +100,7 @@ static void rmd256_transform(u32 *state, const __le32 *in) 
	ROUND(bbb, ccc, ddd, aaa, F4, KK1, in[12],  6);



	/* Swap contents of "a" registers */

	tmp = aa; aa = aaa; aaa = tmp;

	swap(aa, aaa);



	/* round 2: left lane */

	ROUND(aa, bb, cc, dd, F2, K2, in[7],   7);
@@ -139,7 +139,7 @@ static void rmd256_transform(u32 *state, const __le32 *in) 
	ROUND(bbb, ccc, ddd, aaa, F3, KK2, in[2],  11);



	/* Swap contents of "b" registers */

	tmp = bb; bb = bbb; bbb = tmp;

	swap(bb, bbb);



	/* round 3: left lane */

	ROUND(aa, bb, cc, dd, F3, K3, in[3],  11);
@@ -178,7 +178,7 @@ static void rmd256_transform(u32 *state, const __le32 *in) 
	ROUND(bbb, ccc, ddd, aaa, F2, KK3, in[13],  5);



	/* Swap contents of "c" registers */

	tmp = cc; cc = ccc; ccc = tmp;

	swap(cc, ccc);



	/* round 4: left lane */

	ROUND(aa, bb, cc, dd, F4, K4, in[1],  11);
@@ -217,7 +217,7 @@ static void rmd256_transform(u32 *state, const __le32 *in) 
	ROUND(bbb, ccc, ddd, aaa, F1, KK4, in[14],  8);



	/* Swap contents of "d" registers */

	tmp = dd; dd = ddd; ddd = tmp;

	swap(dd, ddd);



	/* combine results */

	state[0] += aa;