Commit d721a175 authored Jan 21, 2013 by Tilman Schmidt Committed by David S. Miller Jan 21, 2013

isdn/gigaset: fix zero size border case in debug dump



If subtracting 12 from l leaves zero we'd do a zero size allocation,
leading to an oops later when we try to set the NUL terminator.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 2f62d5aa

drivers/isdn/gigaset/capi.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -248,6 +248,8 @@ static inline void dump_rawmsg(enum debuglevel level, const char *tag,
		CAPIMSG_APPID(data), CAPIMSG_MSGID(data), l,
		CAPIMSG_CONTROL(data));
		l -= 12;
		if (l <= 0)
		return;
		dbgline = kmalloc(3 * l, GFP_ATOMIC);
		if (!dbgline)
		return;