Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d6aec1ca authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Martin K. Petersen
Browse files

scsi: a100u2w: Replace mdelay() with msleep() 



wait_chip_ready() and wait_firmware_ready() are never called in atomic
context.  They call mdelay() to busy wait which is not necessary.  mdelay()
can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 50838500

drivers/scsi/a100u2w.c

+2 −2
Original line number Diff line number Diff line
@@ -143,7 +143,7 @@ static u8 wait_chip_ready(struct orc_host * host) 
	for (i = 0; i < 10; i++) {	/* Wait 1 second for report timeout     */

		if (inb(host->base + ORC_HCTRL) & HOSTSTOP)	/* Wait HOSTSTOP set */

			return 1;

		mdelay(100);

		msleep(100);

	}

	return 0;

}
@@ -155,7 +155,7 @@ static u8 wait_firmware_ready(struct orc_host * host) 
	for (i = 0; i < 10; i++) {	/* Wait 1 second for report timeout     */

		if (inb(host->base + ORC_HSTUS) & RREADY)		/* Wait READY set */

			return 1;

		mdelay(100);	/* wait 100ms before try again  */

		msleep(100);	/* wait 100ms before try again  */

	}

	return 0;

}