Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d6abc59e authored by Lai Siyao's avatar Lai Siyao Committed by Greg Kroah-Hartman
Browse files

staging/lustre/xattr: xattr data may be gone with lock held 



Xattr cached data may be gone, but lock still held, in this case,
refetch xattr from server, otherwise client will return error.

Signed-off-by: default avatarLai Siyao <lai.siyao@intel.com>
Reviewed-on: http://review.whamcloud.com/12952
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3544


Reviewed-by: default avatarBobi Jam <bobijam@hotmail.com>
Reviewed-by: default avatarNathaniel Clark <nathaniel.l.clark@intel.com>
Signed-off-by: default avatarOleg Drokin <oleg.drokin@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3ce08cd7

drivers/staging/lustre/lustre/llite/xattr_cache.c

+12 −7
Original line number Diff line number Diff line
@@ -295,14 +295,19 @@ static int ll_xattr_find_get_lock(struct inode *inode, 




	mutex_lock(&lli->lli_xattrs_enq_lock);

	/* inode may have been shrunk and recreated, so data is gone, match lock

	 * only when data exists. */

	if (ll_xattr_cache_valid(lli)) {

		/* Try matching first. */

	mode = ll_take_md_lock(inode, MDS_INODELOCK_XATTR, &lockh, 0, LCK_PR);

		mode = ll_take_md_lock(inode, MDS_INODELOCK_XATTR, &lockh, 0,

				       LCK_PR);

		if (mode != 0) {

			/* fake oit in mdc_revalidate_lock() manner */

			oit->d.lustre.it_lock_handle = lockh.cookie;

			oit->d.lustre.it_lock_mode = mode;

			goto out;

		}

	}



	/* Enqueue if the lock isn't cached locally. */

	op_data = ll_prep_md_op_data(NULL, inode, NULL, NULL, 0, 0,