Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d67aed63 authored Apr 12, 2013 by Bjorn Helgaas

PCI: Remove __must_check from definitions



The __must_check (gcc "warn_unused_result") attribute only makes sense
when compiling the *caller* of the function, so the attribute should
appear on the declaration in the header file, not on the definition.

The declarations of these functions are already annotated with
__must_check.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

parent b638d7e7

drivers/pci/hotplug/pci_hotplug_core.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -517,7 +517,7 @@ int pci_hp_deregister(struct hotplug_slot *hotplug)
		*
		* Returns 0 if successful, anything else for an error.
		*/
		int __must_check pci_hp_change_slot_info(struct hotplug_slot *hotplug,
		int pci_hp_change_slot_info(struct hotplug_slot *hotplug,
		struct hotplug_slot_info *info)
		{
		if (!hotplug \|\| !info)

drivers/pci/hotplug/shpchp_sysfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -85,7 +85,7 @@ static ssize_t show_ctrl (struct device dev, struct device_attribute attr, cha
		}
		static DEVICE_ATTR (ctrl, S_IRUGO, show_ctrl, NULL);

		int __must_check shpchp_create_ctrl_files (struct controller *ctrl)
		int shpchp_create_ctrl_files (struct controller *ctrl)
		{
		return device_create_file (&ctrl->pci_dev->dev, &dev_attr_ctrl);
		}