Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d592a4a4 authored by Kejian Yan's avatar Kejian Yan Committed by David S. Miller
Browse files

net: hns: Optimise the code in hns_mdio_wait_ready() 



This patch fixes the code to clear pclint warning/info.

Reported-by: default avatarPing Zhang <zhangping5@huawei.com>
Signed-off-by: default avatarKejian Yan <yankejian@huawei.com>
Reviewed-by: default avatarSalil Mehta <salil.mehta@huawei.com>
Signed-off-by: default avatarSalil Mehta <salil.mehta@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6961acfa

drivers/net/ethernet/hisilicon/hns_mdio.c

+6 −4
Original line number Diff line number Diff line
@@ -175,18 +175,20 @@ static int mdio_sc_cfg_reg_write(struct hns_mdio_device *mdio_dev, 
static int hns_mdio_wait_ready(struct mii_bus *bus)

{

	struct hns_mdio_device *mdio_dev = bus->priv;

	u32 cmd_reg_value;

	int i;

	u32 cmd_reg_value = 1;



	/* waitting for MDIO_COMMAND_REG 's mdio_start==0 */

	/* after that can do read or write*/

	for (i = 0; cmd_reg_value; i++) {

	for (i = 0; i < MDIO_TIMEOUT; i++) {

		cmd_reg_value = MDIO_GET_REG_BIT(mdio_dev,

						 MDIO_COMMAND_REG,

						 MDIO_CMD_START_B);

		if (i == MDIO_TIMEOUT)

			return -ETIMEDOUT;

		if (!cmd_reg_value)

			break;

	}

	if ((i == MDIO_TIMEOUT) && cmd_reg_value)

		return -ETIMEDOUT;



	return 0;

}