Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d58cebb7 authored by Jakub Kicinski's avatar Jakub Kicinski Committed by David S. Miller
Browse files

nfp: correct DMA direction in XDP DMA sync 



dma_sync_single_for_*() takes the direction in which the buffer
was mapped, not the direction of the sync.  We should sync XDP
buffers bidirectionally.

Fixes: ecd63a02 ("nfp: add XDP support in the driver")
Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9383b337

drivers/net/ethernet/netronome/nfp/nfp_net_common.c

+2 −2
Original line number Diff line number Diff line
@@ -1498,7 +1498,7 @@ nfp_net_tx_xdp_buf(struct nfp_net *nn, struct nfp_net_rx_ring *rx_ring, 
	txbuf->real_len = pkt_len;



	dma_sync_single_for_device(&nn->pdev->dev, rxbuf->dma_addr + pkt_off,

				   pkt_len, DMA_TO_DEVICE);

				   pkt_len, DMA_BIDIRECTIONAL);



	/* Build TX descriptor */

	txd = &tx_ring->txds[wr_idx];
@@ -1611,7 +1611,7 @@ static int nfp_net_rx(struct nfp_net_rx_ring *rx_ring, int budget) 


			dma_sync_single_for_cpu(&nn->pdev->dev,

						rxbuf->dma_addr + pkt_off,

						pkt_len, DMA_FROM_DEVICE);

						pkt_len, DMA_BIDIRECTIONAL);

			act = nfp_net_run_xdp(xdp_prog, rxbuf->frag + data_off,

					      pkt_len);

			switch (act) {