Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d4b6c488 authored by Tariq Toukan's avatar Tariq Toukan Committed by Saeed Mahameed
Browse files

net/mlx5e: Distribute RSS table among all RX rings 



In default, uniformly distribute the RSS indirection table entries
among all RX rings, rather than restricting this only to the rings
on the close NUMA node. irqbalancer would anyway dynamically override
the default affinities set to the RX rings.
This gives better multi-stream performance and CPU util.

Signed-off-by: default avatarTariq Toukan <tariqt@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent a8c2eb15

drivers/net/ethernet/mellanox/mlx5/core/en.h

+1 −2
Original line number Diff line number Diff line
@@ -925,8 +925,7 @@ void mlx5e_switch_priv_channels(struct mlx5e_priv *priv, 
void mlx5e_activate_priv_channels(struct mlx5e_priv *priv);

void mlx5e_deactivate_priv_channels(struct mlx5e_priv *priv);



void mlx5e_build_default_indir_rqt(struct mlx5_core_dev *mdev,

				   u32 *indirection_rqt, int len,

void mlx5e_build_default_indir_rqt(u32 *indirection_rqt, int len,

				   int num_channels);

int mlx5e_get_max_linkspeed(struct mlx5_core_dev *mdev, u32 *speed);

drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c

+1 −2
Original line number Diff line number Diff line
@@ -663,8 +663,7 @@ int mlx5e_ethtool_set_channels(struct mlx5e_priv *priv, 
	new_channels.params = priv->channels.params;

	new_channels.params.num_channels = count;

	if (!netif_is_rxfh_configured(priv->netdev))

		mlx5e_build_default_indir_rqt(priv->mdev,

					      new_channels.params.indirection_rqt,

		mlx5e_build_default_indir_rqt(new_channels.params.indirection_rqt,

					      MLX5E_INDIR_RQT_SIZE, count);



	if (!test_bit(MLX5E_STATE_OPENED, &priv->state)) {

drivers/net/ethernet/mellanox/mlx5/core/en_main.c

+2 −13
Original line number Diff line number Diff line
@@ -3833,22 +3833,11 @@ u16 mlx5e_get_max_inline_cap(struct mlx5_core_dev *mdev) 
	       2 /*sizeof(mlx5e_tx_wqe.inline_hdr_start)*/;

}



void mlx5e_build_default_indir_rqt(struct mlx5_core_dev *mdev,

				   u32 *indirection_rqt, int len,

void mlx5e_build_default_indir_rqt(u32 *indirection_rqt, int len,

				   int num_channels)

{

	int node = mdev->priv.numa_node;

	int node_num_of_cores;

	int i;



	if (node == -1)

		node = first_online_node;



	node_num_of_cores = cpumask_weight(cpumask_of_node(node));



	if (node_num_of_cores)

		num_channels = min_t(int, num_channels, node_num_of_cores);



	for (i = 0; i < len; i++)

		indirection_rqt[i] = i % num_channels;

}
@@ -3987,7 +3976,7 @@ void mlx5e_build_nic_params(struct mlx5_core_dev *mdev, 
	/* RSS */

	params->rss_hfunc = ETH_RSS_HASH_XOR;

	netdev_rss_key_fill(params->toeplitz_hash_key, sizeof(params->toeplitz_hash_key));

	mlx5e_build_default_indir_rqt(mdev, params->indirection_rqt,

	mlx5e_build_default_indir_rqt(params->indirection_rqt,

				      MLX5E_INDIR_RQT_SIZE, max_channels);

}