Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d479d2cc authored by Jeremy Fitzhardinge's avatar Jeremy Fitzhardinge Committed by Andi Kleen
Browse files

[PATCH] i386: Update smp_call_function* comments 



Update documentation for i386 smp_call_function* functions.

As reported by Randy Dunlap <rdunlap@xenotime.net>

[ I've posted this before but it seems to have been lost along the way. ]

Signed-off-by: default avatarJeremy Fitzhardinge <jeremy@xensource.com>
Signed-off-by: default avatarAndi Kleen <ak@suse.de>
Cc: Randy Dunlap <rdunlap@xenotime.net>
parent 79463318

arch/i386/kernel/smp.c

+15 −10
Original line number Diff line number Diff line
@@ -554,8 +554,10 @@ static void __smp_call_function(void (*func) (void *info), void *info, 
 * @info: An arbitrary pointer to pass to the function.

 * @wait: If true, wait (atomically) until function has completed on other CPUs.

 *

 * Returns 0 on success, else a negative status code. Does not return until

 * remote CPUs are nearly ready to execute <<func>> or are or have finished.

  * Returns 0 on success, else a negative status code.

 *

 * If @wait is true, then returns once @func has returned; otherwise

 * it returns just before the target cpu calls @func.

 *

 * You must not call this function with disabled interrupts or from a

 * hardware interrupt handler or from a bottom half handler.
@@ -617,11 +619,13 @@ int native_smp_call_function_mask(cpumask_t mask, 
 * smp_call_function(): Run a function on all other CPUs.

 * @func: The function to run. This must be fast and non-blocking.

 * @info: An arbitrary pointer to pass to the function.

 * @nonatomic: currently unused.

 * @nonatomic: Unused.

 * @wait: If true, wait (atomically) until function has completed on other CPUs.

 *

 * Returns 0 on success, else a negative status code. Does not return until

 * remote CPUs are nearly ready to execute <<func>> or are or have executed.

 * Returns 0 on success, else a negative status code.

 *

 * If @wait is true, then returns once @func has returned; otherwise

 * it returns just before the target cpu calls @func.

 *

 * You must not call this function with disabled interrupts or from a

 * hardware interrupt handler or from a bottom half handler.
@@ -633,17 +637,18 @@ int smp_call_function(void (*func) (void *info), void *info, int nonatomic, 
}

EXPORT_SYMBOL(smp_call_function);



/*

/**

 * smp_call_function_single - Run a function on another CPU

 * @cpu: The target CPU.  Cannot be the calling CPU.

 * @func: The function to run. This must be fast and non-blocking.

 * @info: An arbitrary pointer to pass to the function.

 * @nonatomic: Currently unused.

 * @nonatomic: Unused.

 * @wait: If true, wait until function has completed on other CPUs.

 *

 * Retrurns 0 on success, else a negative status code.

 * Returns 0 on success, else a negative status code.

 *

 * Does not return until the remote CPU is nearly ready to execute <func>

 * or is or has executed.

 * If @wait is true, then returns once @func has returned; otherwise

 * it returns just before the target cpu calls @func.

 */

int smp_call_function_single(int cpu, void (*func) (void *info), void *info,

			     int nonatomic, int wait)