Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d38d7fda authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Doug Ledford
Browse files

RDMA/qedr: add null check before pointer dereference 



Add null check before dereferencing pointer sgid_attr.ndev
inside function rdma_vlan_dev_vlan_id().

Addresses-Coverity-ID: 1373979
Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: default avatarRam Amrani <Ram.Amrani@cavium.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 6e8484c5

drivers/infiniband/hw/qedr/qedr_cm.c

+6 −4
Original line number Diff line number Diff line
@@ -270,11 +270,13 @@ static inline int qedr_gsi_build_header(struct qedr_dev *dev, 
		return rc;

	}



	if (sgid_attr.ndev) {

		vlan_id = rdma_vlan_dev_vlan_id(sgid_attr.ndev);

		if (vlan_id < VLAN_CFI_MASK)

			has_vlan = true;

	if (sgid_attr.ndev)



		dev_put(sgid_attr.ndev);

	}



	if (!memcmp(&sgid, &zgid, sizeof(sgid))) {

		DP_ERR(dev, "gsi post send: GID not found GID index %d\n",