Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d32b9a81 authored Dec 28, 2016 by Feras Daoud Committed by Doug Ledford Jan 12, 2017

IB/ipoib: Add detailed error message to dev_queue_xmit call



Add a detailed return code to dev_queue_xmit function when
calling to requeue packet via __skb_dequeue.

Signed-off-by: Feras Daoud <ferasda@mellanox.com>
Signed-off-by: Erez Shitrit <erezsh@mellanox.com>
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Doug Ledford <dledford@redhat.com>

parent 89a3987a

drivers/infiniband/ulp/ipoib/ipoib_cm.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -1015,9 +1015,10 @@ static int ipoib_cm_rep_handler(struct ib_cm_id cm_id, struct ib_cm_event even

		while ((skb = __skb_dequeue(&skqueue))) {
		skb->dev = p->dev;
		if (dev_queue_xmit(skb))
		ipoib_warn(priv, "dev_queue_xmit failed "
		"to requeue packet\n");
		ret = dev_queue_xmit(skb);
		if (ret)
		ipoib_warn(priv, "%s:dev_queue_xmit failed to re-queue packet, ret:%d\n",
		__func__, ret);
		}

		ret = ib_send_cm_rtu(cm_id, NULL, 0);

drivers/infiniband/ulp/ipoib/ipoib_main.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -843,10 +843,12 @@ static void path_rec_completion(int status,
		ipoib_put_ah(old_ah);

		while ((skb = __skb_dequeue(&skqueue))) {
		int ret;
		skb->dev = dev;
		if (dev_queue_xmit(skb))
		ipoib_warn(priv, "dev_queue_xmit failed "
		"to requeue packet\n");
		ret = dev_queue_xmit(skb);
		if (ret)
		ipoib_warn(priv, "%s: dev_queue_xmit failed to re-queue packet, ret:%d\n",
		__func__, ret);
		}
		}

drivers/infiniband/ulp/ipoib/ipoib_multicast.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -314,9 +314,11 @@ static int ipoib_mcast_join_finish(struct ipoib_mcast *mcast,
		netif_tx_unlock_bh(dev);

		skb->dev = dev;
		if (dev_queue_xmit(skb))
		ipoib_warn(priv, "dev_queue_xmit failed to requeue packet\n");

		ret = dev_queue_xmit(skb);
		if (ret)
		ipoib_warn(priv, "%s:dev_queue_xmit failed to re-queue packet, ret:%d\n",
		__func__, ret);
		netif_tx_lock_bh(dev);
		}
		netif_tx_unlock_bh(dev);