Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d2c89a42 authored by Jeff Mahoney's avatar Jeff Mahoney Committed by Linus Torvalds
Browse files

[PATCH] reiserfs: reset errval after initializing bitmap cache 



Callers after reiserfs_init_bitmap_cache() expect errval to contain -EINVAL
until much later.  If a condition fails before errval is reset later,
reiserfs_fill_super() will mistakenly return 0, causing an Oops in
do_add_mount().  This patch resets errval to -EINVAL after the call.

I view this as a temporary fix and real error codes should be used
throughout reiserfs_fill_super().

Signed-off-by: default avatarJeff Mahoney <jeffm@suse.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent d3e5a938

fs/reiserfs/super.c

+1 −0
Original line number Diff line number Diff line
@@ -1619,6 +1619,7 @@ static int reiserfs_fill_super(struct super_block *s, void *data, int silent) 
		      "jmacd-8: reiserfs_fill_super: unable to read bitmap");

		goto error;

	}

	errval = -EINVAL;

#ifdef CONFIG_REISERFS_CHECK

	SWARN(silent, s, "CONFIG_REISERFS_CHECK is set ON");

	SWARN(silent, s, "- it is slow mode for debugging.");