Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d1ee1f02 authored by Herbert Xu's avatar Herbert Xu
Browse files

crypto: aead - Do not set cra_type for new style instances 



The function aead_geniv_alloc currently sets cra_type even for
new style instances.  This is unnecessary and may hide bugs such
as when our caller uses crypto_register_instance instead of the
correct aead_register_instance.

Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 1e419c79

crypto/aead.c

+1 −3
Original line number Diff line number Diff line
@@ -468,12 +468,10 @@ struct aead_instance *aead_geniv_alloc(struct crypto_template *tmpl, 
	    CRYPTO_MAX_ALG_NAME)

		goto err_drop_alg;



	inst->alg.base.cra_flags = CRYPTO_ALG_TYPE_AEAD;

	inst->alg.base.cra_flags |= alg->base.cra_flags & CRYPTO_ALG_ASYNC;

	inst->alg.base.cra_flags = alg->base.cra_flags & CRYPTO_ALG_ASYNC;

	inst->alg.base.cra_priority = alg->base.cra_priority;

	inst->alg.base.cra_blocksize = alg->base.cra_blocksize;

	inst->alg.base.cra_alignmask = alg->base.cra_alignmask;

	inst->alg.base.cra_type = &crypto_new_aead_type;



	inst->alg.ivsize = ivsize;

	inst->alg.maxauthsize = maxauthsize;