Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d1303dd1 authored by Li Zefan's avatar Li Zefan Committed by Steven Rostedt
Browse files

tracing/filters: Add comment for match callbacks 



We should be clear on 2 things:

- the length parameter of a match callback includes
  tailing '\0'.

- the string to be searched might not be NULL-terminated.

Signed-off-by: default avatarLi Zefan <lizf@cn.fujitsu.com>
LKML-Reference: <4B4E8770.7000608@cn.fujitsu.com>
Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
parent 16da27a8

kernel/trace/trace_events_filter.c

+12 −1
Original line number Diff line number Diff line
@@ -252,7 +252,18 @@ static int filter_pred_none(struct filter_pred *pred, void *event, 
	return 0;

}



/* Basic regex callbacks */

/*

 * regex_match_foo - Basic regex callbacks

 *

 * @str: the string to be searched

 * @r:   the regex structure containing the pattern string

 * @len: the length of the string to be searched (including '\0')

 *

 * Note:

 * - @str might not be NULL-terminated if it's of type DYN_STRING

 *   or STATIC_STRING

 */



static int regex_match_full(char *str, struct regex *r, int len)

{

	if (strncmp(str, r->pattern, len) == 0)