Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cfece585 authored by Guennadi Liakhovetski's avatar Guennadi Liakhovetski Committed by Mauro Carvalho Chehab
Browse files

[media] V4L2: ov7670: fix a wrong index, potentially Oopsing the kernel from user-space 



Commit 75e2bdad "ov7670: allow
configuration of image size, clock speed, and I/O method" uses a wrong
index to iterate an array. Apart from being wrong, it also uses an
unchecked value from user-space, which can cause access to unmapped
memory in the kernel, triggered by a normal desktop user with rights to
use V4L2 devices.

Signed-off-by: default avatarGuennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: default avatarJonathan Corbet <corbet@lwn.net>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent e6a62346

drivers/media/i2c/ov7670.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1109,7 +1109,7 @@ static int ov7670_enum_framesizes(struct v4l2_subdev *sd, 
	 * windows that fall outside that.

	 * windows that fall outside that.

	 */

	 */

	for (i = 0; i < n_win_sizes; i++) {

	for (i = 0; i < n_win_sizes; i++) {

		struct ov7670_win_size *win = &info->devtype->win_sizes[index];

		struct ov7670_win_size *win = &info->devtype->win_sizes[i];

		if (info->min_width && win->width < info->min_width)

		if (info->min_width && win->width < info->min_width)

			continue;

			continue;

		if (info->min_height && win->height < info->min_height)

		if (info->min_height && win->height < info->min_height)