Commit cf90bc48 authored May 22, 2013 by Chayan Biswas Committed by Matthew Wilcox May 23, 2013

Return the result from user admin command IOCTL even in case of failure



We copy the result to user if the command is completed from the
controller even if it completes with failure (non-zero) status.
A return status of < 0 indicates the command was not completed
by the controller. The user application may expect the error code
in the result field in case of failure.

Signed-off-by: Chayan Biswas <Chayan.Biswas@sandisk.com>
Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>

parent 053ab702

drivers/block/nvme-core.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1439,7 +1439,7 @@ static int nvme_user_admin_cmd(struct nvme_dev *dev,
	nvme_free_iod(dev, iod);		nvme_free_iod(dev, iod);
	}		}

	if (!status && copy_to_user(&ucmd->result, &cmd.result,		if ((status >= 0) && copy_to_user(&ucmd->result, &cmd.result,
	sizeof(cmd.result)))		sizeof(cmd.result)))
	status = -EFAULT;		status = -EFAULT;