Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cf27020d authored by Alexandru M Stan's avatar Alexandru M Stan Committed by Wolfram Sang
Browse files

i2c: rk3x: fix 0 length write transfers 



i2cdetect -q was broken (everything was a false positive, and no transfers were
actually being sent over i2c). The way it works is by sending a 0 length write
request and checking for NACK. This patch fixes the 0 length writes and actually
sends them.

Reported-by: default avatarDoug Anderson <dianders@chromium.org>
Signed-off-by: default avatarAlexandru M Stan <amstan@chromium.org>
Tested-by: default avatarDoug Anderson <dianders@chromium.org>
Tested-by: default avatarMax Schwarz <max.schwarz@online.de>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
Cc: stable@kernel.org
parent fe82dcec

drivers/i2c/busses/i2c-rk3x.c

+1 −1
Original line number Diff line number Diff line
@@ -238,7 +238,7 @@ static void rk3x_i2c_fill_transmit_buf(struct rk3x_i2c *i2c) 
	for (i = 0; i < 8; ++i) {

		val = 0;

		for (j = 0; j < 4; ++j) {

			if (i2c->processed == i2c->msg->len)

			if ((i2c->processed == i2c->msg->len) && (cnt != 0))

				break;



			if (i2c->processed == 0 && cnt == 0)