Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cef794f7 authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by Mark Brown
Browse files

ASoC: qcom: remove IS_ERR_VALUE usage on int. 



IS_ERR_VALUE should be used only with unsigned long type,
signed types should use comparison 'ret < 0'

This patch removes such usages.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent ea4d25d5

sound/soc/qcom/lpass-platform.c

+4 −2
Original line number Diff line number Diff line
@@ -491,7 +491,7 @@ static int lpass_platform_pcm_new(struct snd_soc_pcm_runtime *soc_runtime) 
			data->rdma_ch = v->alloc_dma_channel(drvdata,

						SNDRV_PCM_STREAM_PLAYBACK);



		if (IS_ERR_VALUE(data->rdma_ch))

		if (data->rdma_ch < 0)

			return data->rdma_ch;



		drvdata->substream[data->rdma_ch] = psubstream;
@@ -518,8 +518,10 @@ static int lpass_platform_pcm_new(struct snd_soc_pcm_runtime *soc_runtime) 
			data->wrdma_ch = v->alloc_dma_channel(drvdata,

						SNDRV_PCM_STREAM_CAPTURE);



		if (IS_ERR_VALUE(data->wrdma_ch))

		if (data->wrdma_ch < 0) {

			ret = data->wrdma_ch;

			goto capture_alloc_err;

		}



		drvdata->substream[data->wrdma_ch] = csubstream;