Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ce89ef36 authored by Tariq Toukan's avatar Tariq Toukan Committed by David S. Miller
Browse files

net/mlx5e: Placement changed for carrier state updates 



More proper to declare carrier state UP only after the channels
are ready for traffic.

Signed-off-by: default avatarTariq Toukan <tariqt@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent daa21560

drivers/net/ethernet/mellanox/mlx5/core/en_main.c

+2 −2
Original line number Diff line number Diff line
@@ -1451,8 +1451,8 @@ int mlx5e_open_locked(struct net_device *netdev) 
		goto err_close_channels;

	}



	mlx5e_update_carrier(priv);

	mlx5e_redirect_rqts(priv);

	mlx5e_update_carrier(priv);

	mlx5e_timestamp_init(priv);



	schedule_delayed_work(&priv->update_stats_work, 0);
@@ -1491,8 +1491,8 @@ int mlx5e_close_locked(struct net_device *netdev) 
	clear_bit(MLX5E_STATE_OPENED, &priv->state);



	mlx5e_timestamp_cleanup(priv);

	mlx5e_redirect_rqts(priv);

	netif_carrier_off(priv->netdev);

	mlx5e_redirect_rqts(priv);

	mlx5e_close_channels(priv);



	return 0;