Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cdb0f9a1 authored by Linus Torvalds's avatar Linus Torvalds
Browse files

selinux: inline avc_audit() and avc_has_perm_noaudit() into caller 



Now that all the slow-path code is gone from these functions, we can
inline them into the main caller - avc_has_perm_flags().

Now the compiler can see that 'avc' is allocated on the stack for this
case, which helps register pressure a bit.  It also actually shrinks the
total stack frame, because the stack frame that avc_has_perm_flags()
always needed (for that 'avc' allocation) is now sufficient for the
inlined functions too.

Inlining isn't bad - but mindless inlining of cold code (see the
previous commit) is.

Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent a554bea8

security/selinux/avc.c

+2 −2
Original line number Diff line number Diff line
@@ -513,7 +513,7 @@ static noinline int slow_avc_audit(u32 ssid, u32 tsid, u16 tclass, 
 * be performed under a lock, to allow the lock to be released

 * before calling the auditing code.

 */

int avc_audit(u32 ssid, u32 tsid,

inline int avc_audit(u32 ssid, u32 tsid,

	       u16 tclass, u32 requested,

	       struct av_decision *avd, int result, struct common_audit_data *a,

	       unsigned flags)
@@ -796,7 +796,7 @@ static noinline int avc_denied(u32 ssid, u32 tsid, 
 * auditing, e.g. in cases where a lock must be held for the check but

 * should be released for the auditing.

 */

int avc_has_perm_noaudit(u32 ssid, u32 tsid,

inline int avc_has_perm_noaudit(u32 ssid, u32 tsid,

			 u16 tclass, u32 requested,

			 unsigned flags,

			 struct av_decision *avd)