Commit cd9d7213 authored Apr 07, 2016 by Sudip Mukherjee Committed by Marcel Holtmann Apr 08, 2016

ieee802154/adf7242: fix memory leak of firmware



If the firmware upload or the firmware verification fails then we
printed the error message and exited but we missed releasing the
firmware.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

parent feb2add3

drivers/net/ieee802154/adf7242.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1030,6 +1030,7 @@ static int adf7242_hw_init(struct adf7242_local *lp)
		if (ret) {
		dev_err(&lp->spi->dev,
		"upload firmware failed with %d\n", ret);
		release_firmware(fw);
		return ret;
		}

		@@ -1037,6 +1038,7 @@ static int adf7242_hw_init(struct adf7242_local *lp)
		if (ret) {
		dev_err(&lp->spi->dev,
		"verify firmware failed with %d\n", ret);
		release_firmware(fw);
		return ret;
		}