Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cd22874f authored by Kees Cook's avatar Kees Cook Committed by Martin K. Petersen
Browse files

scsi: qedf: Avoid reading past end of buffer 



Using memcpy() from a string that is shorter than the length copied
means the destination buffer is being filled with arbitrary data from
the kernel rodata segment. Instead, use strncpy() which will fill the
trailing bytes with zeros.

This was found with the future CONFIG_FORTIFY_SOURCE feature.

Cc: Daniel Micay <danielmicay@gmail.com>
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Acked-by: default avatarChad Dupuis <chad.dupuis@cavium.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 0d2fc3b4

drivers/scsi/qedf/qedf_main.c

+1 −1
Original line number Diff line number Diff line
@@ -2895,7 +2895,7 @@ static int __qedf_probe(struct pci_dev *pdev, int mode) 
	slowpath_params.drv_minor = QEDF_DRIVER_MINOR_VER;

	slowpath_params.drv_rev = QEDF_DRIVER_REV_VER;

	slowpath_params.drv_eng = QEDF_DRIVER_ENG_VER;

	memcpy(slowpath_params.name, "qedf", QED_DRV_VER_STR_SIZE);

	strncpy(slowpath_params.name, "qedf", QED_DRV_VER_STR_SIZE);

	rc = qed_ops->common->slowpath_start(qedf->cdev, &slowpath_params);

	if (rc) {

		QEDF_ERR(&(qedf->dbg_ctx), "Cannot start slowpath.\n");